radekkozak / discordian

Obsidian dark theme inspired by Discord
MIT License
105 stars 4 forks source link

Horizontal scrolling not available for long tables inside Preview mode #20

Closed Gadwood closed 3 years ago

Gadwood commented 3 years ago

Capture d’écran, le 2021-01-25 à 19 37 21 Capture d’écran, le 2021-01-25 à 19 40 37 Corpus de connaissances en management de projet (PMBoK).md.zip

Gadwood commented 3 years ago

Ho last update juste remove the bug! As a second issue is it normal that the "X" to close the setting page is offset of center?

radekkozak commented 3 years ago

Hi again Guillaume, no - the "X" should be all OK. From what i see you do not use Discordian's fonts (Catamaran) which as - from my description in the repo:

IMPORTANT: For best experience possible, please download the fonts and install them in your system before using the theme. Provided fonts closely resemble those in Discord app and are sort of required here

Download fonts and all should be A-OK + using theme will be much more enjoyable ;)

radekkozak commented 3 years ago

As to Horizontal ScrollBar - do you still have the issue ? I designed the theme so there is no horizontal scrollbar because it is visually cluttering whole note but i can see i missed the tables so while checking your provided note in zip file i see the bar and can scroll.

To be honest i would love to remove it in next release, because - same as with long codeblocks - you can easily scroll such parts with Shift button. I will have to think about it though /cc @Gadwood

Gadwood commented 3 years ago

For the issue it’s gone. I did not knew we can side scroll with shift. Thank you

Téléchargez Outlook pour iOShttps://aka.ms/o0ukef


De : Radek Kozak notifications@github.com Envoyé : Wednesday, January 27, 2021 4:39:44 AM À : radekkozak/discordian discordian@noreply.github.com Cc : Gadwood guillaume@gadbois.cc; Author author@noreply.github.com Objet : Re: [radekkozak/discordian] Horizontal scrolling bar (#20)

As to Horizontal ScrollBar - do you still have the issue ? I designed the theme so there is no horizontal scrollbar because it is visually cluttering whole note but i can see i missed the tables so while checking your provided note in zip file i see the bar and can scroll.

To be honest i would love to remove it in next release, because - same as with long codeblocks - you can easily scroll such parts with **Shift" button. I will have to think about it though

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/radekkozak/discordian/issues/20#issuecomment-768161419, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQRUZ3QUQ44VJSMQWMJCFJDS37NOBANCNFSM4WSTITHQ.

dy-sh commented 3 years ago

Hello. I have the same bug. No horizontal bar on page with large table in view mode. Last theme and plugin.

radekkozak commented 3 years ago

Hi @derwish-pro , as i already explained answering @Gadwood - there is no horizontal bar in note "by design" because it only clutters the view but you should easily scroll everything that requires horizontal scrollbar by scrolling with Shift pressed. Have you tried that ?

Is the horizontal scrollbar necessary for you - i could provide a quick snippet fix for you in such case if you can't do with the solution above.

Also it would be very helpful if you could attach the problematic note so i could debug the problem in depth. Thanks !

dy-sh commented 3 years ago

It works with Shift only in the edit mode. In view mode it doesn`t. Any wide table is problematic. Try | 11 | 11 | 11 | ... many times.

radekkozak commented 3 years ago

Hi @derwish-pro , sorry for delay. Yes i was able to reproduce the problem - indeed you were right, something was off with Preview mode. I already have working solution - so thank you for spotting this. Will be out in next version with other fixes.

Still i'm for no horizontal bars if there is Shift+scroll working - it looks so much better on overall UI. But i'm wondering what do you think - is the lack of visual h-scrollbar disturbing ? Or maybe i should just make it an option in the plugin for the user to decide - would that be ok ? Let me know

Thanks once again for reporting the issue, appreciated

dy-sh commented 3 years ago

It would be great to have the option