search

radekkozak / discordian

Obsidian dark theme inspired by Discord
MIT License
105 stars 4 forks source link

Fix scroll bar overlap issue #40

Closed louy closed 3 years ago

louy commented 3 years ago

More permanent fix for #35, on top of #39

Before:

Screenshot 2021-03-17 at 13 23 15

After:

Screenshot 2021-03-17 at 13 38 05
radekkozak commented 3 years ago

Thanks again for the patch @louy

In all frankness i had it like that with those paddings on my local machine, but i decided to sacrifice the visuals for maintaining proper width between Editor and Preview mode (as i mentioned in #35)

After rethinking i agree it is better that way as you propose here after all. If you have and idea how to stick with this and still have no width-shifts between modes - shoot me. I'm open. I did try few quick things from top of my head but none is playing along

What i mean by width shifts is this : toggle off side panels and width Readable line length option in the plugin set for, say 60rem) you will see slight shift of texts going from Editor to Preview (from broader to narrower)

louy commented 3 years ago

Is #41 what you're looking for?

radekkozak commented 3 years ago

Is #41 what you're looking for?

Well, not quite, to be honest. It does brings back left shift in order after your previous patch but it does not respect width.

It needs to take into account vertical scrollbar which is not part of the content in Editor mode (hence the 1rem diff in my code) Secondly it visually brakes Line numbers when enabled and in effect functionally folding does not work when both are enabled as well (due to shift of the gutter)

But the good thing is i took some time and i think we can make it work with the patches provided before. Changes are simple but they do bring everything in order as i quickly tested.

I'm gonna comment on the #41 code so maybe you could change it right there and i could merge everything once done.

And again, big thanks ! Two heads are better than one hehe /cc @louy