Fix `apheleia-npx` in Yarn PnP projects

radian-software / apheleia

🌷 Run code formatter on buffer contents without moving point, using RCS patches and dynamic programming.

MIT License

517 stars 73 forks source link

Open zeorin opened 2 months ago

zeorin commented 2 months ago

apheleia-npx would use an incorrect path for the Yarn PnP ESM loader.
apheleia-npx did not correctly guard against word splitting.
apheleia-npx was sometimes not able to find formatters in a Yarn PnP project if there was also a node_modules folder at the root of the project. Unfortunately, many tools (including Prettier) will create a cache folder in node_modules even in Yarn PnP projects. The presence of any node_modules folders are irrelevant when a .pnp.cjs file is present.

zeorin commented 2 months ago

raxod502 commented 1 month ago

LGTM generally. Looks like upstream changes broke the tests. I'll fix, and also make sure we have test coverage that actually validates this change.