Closed gurhar1133 closed 1 year ago
Looks like only test failing is the compatibility test
One test is failing for me, tests/pulse_test.py::test_sirepo_compatability FAILED
It looks like this branch was created prior to the most recent PR, merged yesterday.
The signature for the Drift and other classes has changed, so there will likely be some problems when this PR is merged.
That is the test that checks compatibility with what is on sirepo master. The references Drift
Lens
etc are what sirepo master will generate. So the test failure indicates that what is on rlsaser rn will break sirepo. Which is the case (working on fixing it currently). So it's good that that test is failing. Sorry @bruhwiler I didn't specify in PR
sirepo PR where I fixed to reflect new rslaser API
OK, fixes were merged in sirepo, so I am updating the test to reflect sirepo master
@bruhwiler test is passing, showing that sirepo master is consistent with latest rslaser
Tests elements and pulse to see if they are compatable with sirepo silas master branch