radical-cybertools / radical.pilot

RADICAL-Pilot
http://radical-cybertools.github.io/radical-pilot/index.html
Other
54 stars 23 forks source link

some bash versions require EOL cont for bracketed calls #2955

Closed andre-merzky closed 1 year ago

andre-merzky commented 1 year ago

No idea why, but recently my new system started complaining about a shell syntax error. I guess this went unnoticed before because of some leniency in the bash parser. Either way, this PR fixes the syntax error.

codecov[bot] commented 1 year ago

Codecov Report

Merging #2955 (df9c9ab) into devel (a07cf59) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##            devel    #2955   +/-   ##
=======================================
  Coverage   41.44%   41.44%           
=======================================
  Files          95       95           
  Lines       10483    10483           
=======================================
  Hits         4345     4345           
  Misses       6138     6138           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

andre-merzky commented 1 year ago

LGTM! (looks like a leftover, other parts in bootstrapper are covered)

Yes indeed...

andre-merzky commented 1 year ago

Any idea which bash version? Anyway, this LGTM as well.

I was actually wrong - we use /bin/sh in the bootstrapper, and on my system that points to dash with version 0.5.12.