radical-cybertools / radical.pilot

RADICAL-Pilot
http://radical-cybertools.github.io/radical-pilot/index.html
Other
54 stars 23 forks source link

stub slurm test #2998

Closed andre-merzky closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #2998 (d3aafbf) into devel (13852db) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##            devel    #2998   +/-   ##
=======================================
  Coverage   41.85%   41.85%           
=======================================
  Files          95       95           
  Lines       10535    10535           
=======================================
  Hits         4409     4409           
  Misses       6126     6126           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

:loudspeaker: Have feedback on the report? Share it here.

mtitov commented 1 year ago

I would propose to have it as a bash script that will submit a batch script, and thus having the following format for a command: radical-pilot-test-slurm -a <account> -p <partition> [--exclusive]. The last parameter is to test an exclusive approach (--exclusive option in SBATCH and --exact option in SRUN) and which is optional (so we can test without it first, and then with it)

I also would use our SRUN options here, such as --nodes, --ntasks, --cpus-per-task, --mem 0, --nodelist (since we need to ensure all these options)

andre-merzky commented 1 year ago

I would propose to have it as a bash script that will submit a batch script, and thus having the following format for a command: radical-pilot-test-slurm -a <account> -p <partition> [--exclusive]. The last parameter is to test an exclusive approach (--exclusive option in SBATCH and --exact option in SRUN) and which is optional (so we can test without it first, and then with it)

I also would use our SRUN options here, such as --nodes, --ntasks, --cpus-per-task, --mem 0, --nodelist (since we need to ensure all these options)

That all makes sense, will implement. Thanks!