radical-cybertools / radical.pilot

RADICAL-Pilot
http://radical-cybertools.github.io/radical-pilot/index.html
Other
54 stars 23 forks source link

Devel nodb 2 #3016

Closed mtitov closed 1 year ago

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

codecov[bot] commented 1 year ago

Codecov Report

Merging #3016 (5a517f1) into devel (c8a2705) will increase coverage by 0.56%. The diff coverage is 35.79%.

@@            Coverage Diff             @@
##            devel    #3016      +/-   ##
==========================================
+ Coverage   41.85%   42.41%   +0.56%     
==========================================
  Files          95       99       +4     
  Lines       10535    10824     +289     
==========================================
+ Hits         4409     4591     +182     
- Misses       6126     6233     +107     
Files Coverage Δ
src/radical/pilot/__init__.py 100.00% <100.00%> (ø)
src/radical/pilot/agent/executing/base.py 74.48% <100.00%> (-10.36%) :arrow_down:
src/radical/pilot/agent/launch_method/mpirun.py 85.47% <ø> (ø)
src/radical/pilot/agent/resource_manager/base.py 90.29% <100.00%> (+0.04%) :arrow_up:
src/radical/pilot/agent/resource_manager/fork.py 100.00% <100.00%> (ø)
src/radical/pilot/constants.py 100.00% <100.00%> (ø)
src/radical/pilot/messages.py 100.00% <100.00%> (ø)
src/radical/pilot/resource_description.py 100.00% <100.00%> (ø)
src/radical/pilot/utils/misc.py 50.81% <100.00%> (ø)
src/radical/pilot/worker/__init__.py 100.00% <ø> (ø)
... and 35 more

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

mturilli commented 1 year ago

An initial look at the logs of staging with @mtitov shows that there seem to be an issue with the tutorial and the use of relative vs. full paths for staging data. If that is the case, we should fix the tutorial but also add a discussion of paths to the tutorial itself. @andre-merzky you may want to have a look/help with that.

mturilli commented 1 year ago

@andre-merzky do we need to fix the unit test? https://github.com/radical-cybertools/radical.pilot/actions/runs/6151031997/job/16690246955?pr=3016

mturilli commented 1 year ago

@andre-merzky @mtitov for describing_tasks, see errors in agent_executing.0000.log.