radical-cybertools / radical.pilot

RADICAL-Pilot
http://radical-cybertools.github.io/radical-pilot/index.html
Other
54 stars 23 forks source link

Option `--ppn` in MPIEXEC LM #3035

Closed mtitov closed 11 months ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #3035 (9118318) into devel (6170236) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            devel    #3035      +/-   ##
==========================================
+ Coverage   43.98%   43.99%   +0.01%     
==========================================
  Files          96       96              
  Lines       10568    10570       +2     
==========================================
+ Hits         4648     4650       +2     
  Misses       5920     5920              
Files Coverage Δ
src/radical/pilot/agent/launch_method/mpiexec.py 88.57% <100.00%> (+0.16%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

mturilli commented 12 months ago

@GKNB does this PR implements the behavior you expected?

andre-merzky commented 11 months ago

@GKNB does this PR implements the behavior you expected?

ping?

GKNB commented 11 months ago

I think this branch is also consistent with the main devel branch now, and in the main devel branch I can see a --ppn flag is already added for each task and it runs successfully for the mini-app, so I think it works fine.

mtitov commented 11 months ago

confirmed with the test run on Polaris