radical-cybertools / radical.pilot

RADICAL-Pilot
http://radical-cybertools.github.io/radical-pilot/index.html
Other
54 stars 23 forks source link

clear RAPTOR and Configuration tutorials notebooks #3066

Closed AymenFJA closed 11 months ago

review-notebook-app[bot] commented 11 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

codecov[bot] commented 11 months ago

Codecov Report

Merging #3066 (e4829ce) into devel (5318046) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##            devel    #3066   +/-   ##
=======================================
  Coverage   43.90%   43.90%           
=======================================
  Files          96       96           
  Lines       10563    10563           
=======================================
  Hits         4638     4638           
  Misses       5925     5925           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

AymenFJA commented 11 months ago

multiple_pilots and specifically pilot.00001 only fail with:

 /home/runner/radical.pilot.sandbox/rp.session.fv-az410-569.runner.019649.0000/pilot.0001//bootstrap_0.sh: line 912: /home/runner/radical.pilot.sandbox/rp.session.fv-az410-569.runner.019649.0000/pilot.0001/bin/activate: No such file or directory
 39 Loading of virtual env failed!
mtitov commented 11 months ago

Looks like it is a race condition, and pilots on the same machine can interfere with each other

from bootstrap_0.out

VIRTENV           : /home/runner/radical.pilot.sandbox/ve.local.localhost.1.42.0
/home/runner/radical.pilot.sandbox/rp.session.fv-az410-569.runner.019649.0000/pilot.0001//bootstrap_0.sh: line 1595: cd: /home/runner/radical.pilot.sandbox/ve.local.localhost.1.42.0: No such file or directory
VIRTENV normalized: /home/runner/radical.pilot.sandbox/rp.session.fv-az410-569.runner.019649.0000/pilot.0001

and this does from here https://github.com/radical-cybertools/radical.pilot/blob/7a4b73ee99f029e8689f4b5e305c90ab148e45c0/src/radical/pilot/agent/bootstrap_0.sh#L1594-L1596

and it is possible for some pilot to have incorrect VIRTENV env variable