radical-cybertools / radical.pilot

RADICAL-Pilot
http://radical-cybertools.github.io/radical-pilot/index.html
Other
54 stars 23 forks source link

amarel cfg #3076

Closed andre-merzky closed 11 months ago

andre-merzky commented 11 months ago

as discussed: use exclusive and exact options on amatel.

@mtitov : Maybe we can change the check in the srun LM to something like

if submitted_with_exclusive:
    self._exact == True

?

mtitov commented 11 months ago

@mtitov : Maybe we can change the check in the srun LM to something like

if submitted_with_exclusive:
    self._exact == True

?

yeah, that works

codecov[bot] commented 11 months ago

Codecov Report

Merging #3076 (71fa4a4) into devel (4d3ee16) will not change coverage. The diff coverage is 75.00%.

@@           Coverage Diff           @@
##            devel    #3076   +/-   ##
=======================================
  Coverage   43.99%   43.99%           
=======================================
  Files          96       96           
  Lines       10570    10570           
=======================================
  Hits         4650     4650           
  Misses       5920     5920           
Files Coverage Δ
src/radical/pilot/agent/resource_manager/base.py 90.29% <100.00%> (ø)
src/radical/pilot/agent/launch_method/srun.py 90.62% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

mtitov commented 11 months ago

@andre-merzky ~should we try to automate this process by checking env variableSBATCH_EXCLUSIVE (https://slurm.schedmd.com/sbatch.html#OPT_SBATCH_EXCLUSIVE)? if it is set, then to use exact~

edit: it is an input env variable.. looks like not applicable for us

andre-merzky commented 11 months ago

@andre-merzky ~should we try to automate this process by checking env variableSBATCH_EXCLUSIVE (https://slurm.schedmd.com/sbatch.html#OPT_SBATCH_EXCLUSIVE)? if it is set, then to use exact~

edit: it is an input env variable.. looks like not applicable for us

I added code to lookup the system_architecture flags. How does that look to you?