search

radio-astro-tools / spectral-cube

Library for reading and analyzing astrophysical spectral data cubes
http://spectral-cube.rtfd.org
BSD 3-Clause "New" or "Revised" License
95 stars 62 forks source link

implement APE14 compatibility in reproject #778

Open keflavich opened 2 years ago

keflavich commented 2 years ago

Solves #777

This is a fairly straightforward PR but needs tests.

codecov-commenter commented 2 years ago

Codecov Report

Merging #778 (dea4a27) into master (1f67a8f) will decrease coverage by 0.06%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #778      +/-   ##
==========================================
- Coverage   77.86%   77.80%   -0.07%     
==========================================
  Files          24       24              
  Lines        5811     5816       +5     
==========================================
  Hits         4525     4525              
- Misses       1286     1291       +5
Impacted Files Coverage Δ
spectral_cube/spectral_cube.py 76.55% <0.00%> (-0.26%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1f67a8f...dea4a27. Read the comment docs.

keflavich commented 2 years ago

This is not even close to straightforward. I don't think spectral-cube can or should support any non-serializable WCSes.