search

radius-project / samples

Radius samples
32 stars 26 forks source link

Add signoff to `Upmerge samples to edge` workflow #1884

Open willdavsmith opened 2 weeks ago

willdavsmith commented 2 weeks ago

The Upmerge samples to edge workflow does not include a signoff message in the commit: https://github.com/radius-project/samples/blob/f92e009a248f05f3511c49e483259e89de48f2d1/.github/workflows/upmerge.yaml#L65

This causes DCO to fail during the release process. We should add a signoff flag to the git merge command.

AB#13662

ytimocin commented 2 weeks ago

Closing this now @willdavsmith. You can re-open if it is not fixed already.

kachawla commented 6 days ago

This hasn't been fixed yet, re-opening and removing triage label.

brooke-hamilton commented 3 days ago

/assign