Open raduprv opened 7 years ago
Are you intending to keep one code base for the desktop client and this port to Android?
I think we should use the same code base for both, because some of the things done for Android, such as touch based gestures and OpenGL ES would be useful for non Android devices as well. However, we should probably have some source files especially done for Android, and add them to the Android build.
OK. I do not know much about C/C++ on Android. Do you intend to the Android NDK and the Android Studio build system?
Yes, I did play with some SDL2 programs 2 years ago. I will try it as soon as we get the SDl2 port ready.
I posted on the forums a few weeks ago about modifying the client UI components to be scalable for high DPI screens. I was thinking to to make each component individually scalable but with a global setting also applied. The main work will be in making each of the components work in this way. I think this would be useful for the Android / touch changes too. What do you think?
Yes, I think it's a good idea.
So, Sir Odie worked at the SDL2 port, and he got a working client! There are some problems, but it is functional. pjbroad, can you take a look at the SDL2 branch, and try to fix some of the keyboard handling issues? Sir Odie is not familiar with the GUI/interface system.
Some compile failures on Linux. http://pastebin.com/raw/NbLsZn7j And the Makefile needs to call sdl2-config.
I have no Linux to test atm, so please test if my last patch helps.
CC events.o events.c: In function ‘HandleEvent’: events.c:105:20: error: ‘SDL_SysWMEvent {aka struct SDL_SysWMEvent}’ has no member named ‘x11’ if (event->syswm.x11->event.xevent.type == SelectionNotify) ^ events.c:106:29: error: ‘SDL_SysWMEvent {aka struct SDL_SysWMEvent}’ has no member named ‘x11’ finishpaste(event->syswm.x11->event.xevent.xselection); ^ events.c:107:25: error: ‘SDL_SysWMEvent {aka struct SDL_SysWMEvent}’ has no member named ‘x11’ else if (event->syswm.x11->event.xevent.type == SelectionRequest) ^ events.c:108:31: error: ‘SDL_SysWMEvent {aka struct SDL_SysWMEvent}’ has no member named ‘x11’ process_copy(&event->syswm.x11->event.xevent.xselectionrequest); ^ make: *\ [Makefile.linux:119: events.o] Error 1
If this is in relation to the Android port, those things will be #ifdefed out anyway, as they are X11 related.
@raduprv, If you mean my build error, no it was on Linux. So I'm sorry for posting in the wrong place.
I would suggest keeping the logging for dispute resolution and moderator assistance. The ability to purge the logs to an email would help keep bloat down. The ability send the day's logs to a moderator would be helpful. Or the moderators could pull logs. ;)
As I was mentioning, the logs are not accessible outside of the EL app (except on rooted devices).
Shall we close this one?
Ok, so I've been thinking about the Android port for the last few days, and I think the following things need to be done:
Things that have to be removed from the client:
Things that have to be added:
Things that have to be changed:
This should be about it. Let me know if you think I missed something, or if you have some other ideas.