reubenhwk
commented
10 years ago It all looks good. I'm going to merge this into master and the radvd-2 branch. The 7466cf9 commit happened to be fixed in radvd-2 in a libdaemon/cleanup fix.
On Tue, Apr 8, 2014 at 6:29 PM, Cristian Rodríguez <notifications@github.com
wrote:
e36f3c0 https://github.com/reubenhwk/radvd/commit/e36f3c0 : Adds compiler type checking of format strings.
7466cf9 https://github.com/reubenhwk/radvd/commit/7466cf9: flog(LOG_INFO, "sending stop adverts", pidfile); clearly has an extra unintented argument.
1a85e4d https://github.com/reubenhwk/radvd/commit/1a85e4d: Use correct
format for size_t (%zu)
You can merge this Pull Request by running
git pull https://github.com/crrodriguez/radvd master
Or view, comment on, or merge it at:
https://github.com/reubenhwk/radvd/pull/27 Commit Summary
- Add compiler attributes to type check format strings
- Fix radvd.c:342:2: warning: too many arguments for format [-Wformat-extra-args]
- Fix format string warnings
File Changes
- M log.c https://github.com/reubenhwk/radvd/pull/27/files#diff-0(1)
- M log.h https://github.com/reubenhwk/radvd/pull/27/files#diff-1(4)
- M radvd.c https://github.com/reubenhwk/radvd/pull/27/files#diff-2(2)
- M recv.c https://github.com/reubenhwk/radvd/pull/27/files#diff-3(4)
Patch Links:
— Reply to this email directly or view it on GitHubhttps://github.com/reubenhwk/radvd/pull/27 .
e36f3c0 : Adds compiler type checking of format strings.
7466cf9: flog(LOG_INFO, "sending stop adverts", pidfile); clearly has an extra unintented argument.
1a85e4d: Use correct format for size_t (%zu)