raethkcj / RatingBuster

An item comparison tool for WoW Classic.
GNU General Public License v2.0
57 stars 14 forks source link

[Bug]: Is druid attack power calculating correctly? #107

Closed OnceWasPerfect closed 1 year ago

OnceWasPerfect commented 1 year ago

Describe the bug

I was trying to decide between the Dragonfriend Bracers and the Deadly Gladiator's Armwraps of Triumph and the difference in Power that the character screen reports and what Rating Buster reports are different. I may have a setting wrong or something but I couldn't figure it out. The character sheet reports my attack power with Dragonfriend Bracers on as 6370 and when I swap them for the PVP bracers it shows 6278, a difference of 92. Rating Buster shows that there should be a Feral Attack Power difference of 48 and an Attack Power difference of 38.6. Neither of those are correct if i'm only supposed to use one and added together they are only 86.6. Then I thought maybe it's the difference in Agility 67.7 vs 59.3 which is 8.4 but when you add that to the 86.6 you get 95 more than the 92 the character sheet shows. I've attached some screenshots. Notice I have ignore enchants set so that shouldn't be affecting it.

PS: When in caster form my character sheet shows my AP as 2114 with the Dragonfriend Bracers and 2022 with the PVP bracers, a different of 92. Rating Buster shows a Feral AP difference of 51.4 and an AP difference of 42.8.

feral1 feral2 feral3

Addon Source

GitHub Releases

Version

1.5.14

Locale

English

Talent Specialization

Feral Druid

Race

Tauren

raethkcj commented 1 year ago

I don't have time for a full fix just now, but I can confirm it is bugged and about 20% too high. Thanks.

OnceWasPerfect commented 1 year ago

Awesome thank you, for my own knowledge when comparing items as a feral should I be using both the regular Attack Power and Feral Attack Power in ratingbuster or is Feral Attack Power supposed to take all that into account?

raethkcj commented 1 year ago

Feral Attack Power is intended to take that into account. Honestly this is pretty unclear and I think I'd like to rework it into separate "Cat Form Attack Power" and "Bear Form Attack Power" as right now it's trying to do both and succeeding at neither.

The goal would be: Attack Power: Shows actual current AP provided by the item, including in caster/moonkin forms where it may be low. Cat Form Attack Power: Shows the AP the item will provide in Cat Form, regardless of which form you're in. Bear Form Attack Power: Shows the AP the item will provide in Bear Form, regardless of which form you're in.

The current "Feral Attack Power" is a bit strange, and I believe it will show Bear Form Attack Power in all forms except for Cat, when it will change to showing Cat Form Attack Power.

OnceWasPerfect commented 1 year ago

Awesome, thank you for the info. What you describes sounds like it would be great, in the mean time I understand what ratingbuster is telling me a bit better. Thanks!

raethkcj commented 1 year ago

It turns out that several of the problems here were caused by trying to predict Feral AP while not in forms, and ultimately there's not a good way to solve them in a way that makes sense for everyone without bringing in an external addon like RatingBuster AlwaysBuffed, which hasn't been ported to Classic.

Therefore, I've simply removed Feral AP as its own Summary line, and instead Druids should use the regular Sum AP, which will show the actual current AP provided by an item in their current form.

I tested with several talent setups, in all of Caster Form, Cat Form, and Dire Bear Form, and the numbers should match the changes in your character sheet while in those forms.