search

rafi0101 / Android-Room-Database-Backup

Simple tool to backup and restore your room database in Android
MIT License
239 stars 19 forks source link

Replaced database shutdown with checkpoint for backup #7

Closed truedem closed 2 years ago

truedem commented 3 years ago

This way there is no need to restart the app after backup so it can be used seamlessly - for automatic daily backups, for example.

rafi0101 commented 3 years ago

Yes, that would be a nice feature.

In your PR, I think you forgot to import the SimpleSQLiteQuery library. At all after importing your changes and doing a backup. I get the error message that you can't access the database on the main thread because the UI may be locked for an extended period of time. Maybe you can put this in an asynchronous task.

truedem commented 3 years ago

GitHub has counter-intuitive UI so I don't know how to proceed with the changes. Already got all the code I need in the local files for my project(s), including custom (language-specific) toasts / error messages / activity restart (your code does not work with launchMode="singleTop" parameter in the manifest).

Just dump the thread / pull request maybe.

rafi0101 commented 3 years ago

I see you deleted your source branch already. Maybe create a new branch, make a new PR (keep the Branch) then you can commit to this branch and see it in the new PR.

Maybe this https://akrabat.com/the-beginners-guide-to-contributing-to-a-github-project/ or this https://kbroman.org/github_tutorial/pages/fork.html helps

rafi0101 commented 2 years ago

I will close this due to no activity