Closed raftmsohani closed 2 months ago
Attention: Patch coverage is 60.00000%
with 10 lines
in your changes missing coverage. Please review.
Project coverage is 91.32%. Comparing base (
fbd4d67
) to head (8dd593b
). Report is 11 commits behind head on develop.
Files with missing lines | Patch % | Lines |
---|---|---|
tdrs-backend/tdpservice/data_files/admin/admin.py | 60.00% | 9 Missing and 1 partial :warning: |
@raftmsohani LGTM from a11y perspective. I noticed that the titles of the widgets are a little inconsistent with title casing. Can it be changed to:
By submission date
instead ofBy Submission Date
please? Lastly, can we switch Today and Yesterday so the list is in chronological order please? I noticedBy Program Type
is the other inconsistent title. Thank you!
Good call, will do @victoriaatraft !
Summary of Changes
Pull request closes #3076 _
How to Test
These steps are generic, please adjust as necessary.
DataFile.objects.get(id=X)
and then change submission data by using:df.created_at=datetime.now(tz=timezone.utc)-timedelta(days=2)
I did change submission date, and tested for different values, and all worked fine.
Deliverables
More details on how deliverables herein are assessed included here.
Deliverable 1: Accepted Features
Checklist of ACs:
lfrohlich
and/oradpennington
confirmed that ACs are met.Deliverable 2: Tested Code
CodeCov Report
comment in PR)CodeCov Report
comment in PR)Deliverable 3: Properly Styled Code
Deliverable 4: Accessible
iamjolly
andttran-hub
using Accessibility Insights reveal any errors introduced in this PR?Deliverable 5: Deployed
Deliverable 6: Documented
Deliverable 7: Secure
Deliverable 8: User Research
Research product(s) clearly articulate(s):