Fiscal Year Multiselect

elipe17 commented 3 months ago

Summary of Changes

To support multi select, introduced two new multi select filters. One for the year and one for the quarter since it was impossible to keep it at a single filter with our current multi select filter capabilities.
Updated the 508 repo with this PR to reflect the changes here and impending re-architecting in #3110 Pull request closes #3102

How to Test

cd tdrs-frontend && docker-compose up
cd tdrs-backend && docker-compose up --build

Open http://localhost:3000/ and sign in.
Submit some data
Visit the search indexes page(s) of your choice and begin filtering. Note how each multiselect filter has it's own filter button again. This was a requirement to have more than one multiselect on a page.
Ensure the filtered data matches your selections

Deliverables

More details on how deliverables herein are assessed included here.

Deliverable 1: Accepted Features

Checklist of ACs:

[x] Search Indexes pages have multiselect fiscal period filter
[x] Testing Checklist has been run and all tests pass
[x] README is updated, if necessary

Deliverable 2: Tested Code

Are all areas of code introduced in this PR meaningfully tested?
- [x] If this PR introduces backend code changes, are they meaningfully tested?
- [ ] If this PR introduces frontend code changes, are they meaningfully tested?
Are code coverage minimums met?
- [x] Frontend coverage: [insert coverage %] (see CodeCov Report comment in PR)
- [x] Backend coverage: [insert coverage %] (see CodeCov Report comment in PR)

Deliverable 3: Properly Styled Code

[x] Are backend code style checks passing on CircleCI?
[x] Are frontend code style checks passing on CircleCI?
[x] Are code maintainability principles being followed?

Deliverable 4: Accessible

[ ] Does this PR complete the epic?
[ ] Are links included to any other gov-approved PRs associated with epic?
[ ] Does PR include documentation for Raft's a11y review?
[ ] Did automated and manual testing with iamjolly and ttran-hub using Accessibility Insights reveal any errors introduced in this PR?

Deliverable 5: Deployed

[x] Was the code successfully deployed via automated CircleCI process to development on Cloud.gov?

Deliverable 6: Documented

[x] Does this PR provide background for why coding decisions were made?
[ ] If this PR introduces backend code, is that code easy to understand and sufficiently documented, both inline and overall?
[ ] If this PR introduces frontend code, is that code easy to understand and sufficiently documented, both inline and overall?
[ ] If this PR introduces dependencies, are their licenses documented?
[x] Can reviewer explain and take ownership of these elements presented in this code review?

Deliverable 7: Secure

[x] Does the OWASP Scan pass on CircleCI?
[ ] Do manual code review and manual testing detect any new security issues?
[ ] If new issues detected, is investigation and/or remediation plan documented?

Deliverable 8: User Research

Research product(s) clearly articulate(s):

[ ] the purpose of the research
[ ] methods used to conduct the research
[ ] who participated in the research
[ ] what was tested and how
[ ] impact of research on TDP
[ ] (if applicable) final design mockups produced for TDP development

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.61%. Comparing base (61df98f) to head (0ffc545). Report is 2 commits behind head on develop.

Additional details and impacted files

[![Impacted file tree graph](https://app.codecov.io/gh/raft-tech/TANF-app/pull/3151/graphs/tree.svg?width=650&height=150&src=pr&token=BA04YXPAL9&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech)](https://app.codecov.io/gh/raft-tech/TANF-app/pull/3151?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) ```diff @@ Coverage Diff @@ ## develop #3151 +/- ## =========================================== + Coverage 91.27% 91.61% +0.33% =========================================== Files 291 291 Lines 8072 8075 +3 Branches 757 757 =========================================== + Hits 7368 7398 +30 + Misses 596 594 -2 + Partials 108 83 -25 ``` | [Flag](https://app.codecov.io/gh/raft-tech/TANF-app/pull/3151/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) | Coverage Δ | | |---|---|---| | [dev-backend](https://app.codecov.io/gh/raft-tech/TANF-app/pull/3151/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) | `91.09% <100.00%> (+<0.01%)` | :arrow_up: | | [dev-frontend](https://app.codecov.io/gh/raft-tech/TANF-app/pull/3151/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) | `95.31% <ø> (+2.69%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/raft-tech/TANF-app/pull/3151?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) | Coverage Δ | | |---|---|---| | [...drs-backend/tdpservice/search\_indexes/admin/ssp.py](https://app.codecov.io/gh/raft-tech/TANF-app/pull/3151?src=pr&el=tree&filepath=tdrs-backend%2Ftdpservice%2Fsearch_indexes%2Fadmin%2Fssp.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#diff-dGRycy1iYWNrZW5kL3RkcHNlcnZpY2Uvc2VhcmNoX2luZGV4ZXMvYWRtaW4vc3NwLnB5) | `100.00% <100.00%> (ø)` | | | [...rs-backend/tdpservice/search\_indexes/admin/tanf.py](https://app.codecov.io/gh/raft-tech/TANF-app/pull/3151?src=pr&el=tree&filepath=tdrs-backend%2Ftdpservice%2Fsearch_indexes%2Fadmin%2Ftanf.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#diff-dGRycy1iYWNrZW5kL3RkcHNlcnZpY2Uvc2VhcmNoX2luZGV4ZXMvYWRtaW4vdGFuZi5weQ==) | `100.00% <100.00%> (ø)` | | | [...-backend/tdpservice/search\_indexes/admin/tribal.py](https://app.codecov.io/gh/raft-tech/TANF-app/pull/3151?src=pr&el=tree&filepath=tdrs-backend%2Ftdpservice%2Fsearch_indexes%2Fadmin%2Ftribal.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#diff-dGRycy1iYWNrZW5kL3RkcHNlcnZpY2Uvc2VhcmNoX2luZGV4ZXMvYWRtaW4vdHJpYmFsLnB5) | `100.00% <100.00%> (ø)` | | ... and [12 files with indirect coverage changes](https://app.codecov.io/gh/raft-tech/TANF-app/pull/3151/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/raft-tech/TANF-app/pull/3151?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/raft-tech/TANF-app/pull/3151?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech). Last update [8868eea...0ffc545](https://app.codecov.io/gh/raft-tech/TANF-app/pull/3151?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech).

ADPennington commented 2 months ago

@elipe17 i deployed this to qasp environment and am observing unexpected results when trying to apply any filter. I did clear the browser cache. see below:

multiselect_p1 multiselect_p2 multiselect_p3 multiselect_p4

elipe17 commented 2 months ago

@ADPennington you might have to show me/tell me exactly what your are doing to generate that. I filtered based on your screen shot and everything seems to be working as expected (see below). Let me know how you'd like to proceed. Screenshot 2024-09-09 at 11 52 55 AM

raft-tech / TANF-app