raft-tech / TANF-app

Repo for development of a new TANF Data Reporting System
Other
17 stars 4 forks source link

2990 - stuck files notification #3195

Closed jtimpe closed 1 month ago

jtimpe commented 2 months ago

Summary of Changes

Pull request closes #2990

How to Test

  1. Make sure the SENDGRID_API_KEY env var is set, reach out if you need a valid key
  2. Spin up your environment
    cd tdrs-backend && docker compose up
    cd tdrs-frontend && docker compose up --build
  3. Sign in and change your user role to OFA System Admin
  4. Create some submissions. Using shell_plus, change the created_at to >1hr ago.
  5. Reparse some submissions. Using shell_plus, change the timeout_at to some time in the past. Change finished and success to False.
  6. Run docker compose exec web python manage.py find_pending_submissions.

Try a lot of combinations. If you can get it to fire in real life stuck-file scenarios, that's a plus.

Example of email image

Deliverables

More details on how deliverables herein are assessed included here.

Deliverable 1: Accepted Features

Checklist of ACs:

Deliverable 2: Tested Code

Deliverable 3: Properly Styled Code

Deliverable 4: Accessible

Deliverable 5: Deployed

Deliverable 6: Documented

Deliverable 7: Secure

Deliverable 8: User Research

Research product(s) clearly articulate(s):

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.66%. Comparing base (c15cb7c) to head (1f6756b). Report is 2 commits behind head on develop.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/raft-tech/TANF-app/pull/3195/graphs/tree.svg?width=650&height=150&src=pr&token=BA04YXPAL9&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech)](https://app.codecov.io/gh/raft-tech/TANF-app/pull/3195?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) ```diff @@ Coverage Diff @@ ## develop #3195 +/- ## ======================================== Coverage 92.66% 92.66% ======================================== Files 47 47 Lines 1009 1009 Branches 169 169 ======================================== Hits 935 935 Misses 42 42 Partials 32 32 ``` | [Flag](https://app.codecov.io/gh/raft-tech/TANF-app/pull/3195/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) | Coverage Δ | | |---|---|---| | [dev-frontend](https://app.codecov.io/gh/raft-tech/TANF-app/pull/3195/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) | `92.66% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#carryforward-flags-in-the-pull-request-comment) to find out more. ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/raft-tech/TANF-app/pull/3195?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/raft-tech/TANF-app/pull/3195?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech). Last update [fab247d...1f6756b](https://app.codecov.io/gh/raft-tech/TANF-app/pull/3195?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech).
ADPennington commented 2 months ago

@jtimpe some unit tests are failing on this branch since the reparsing work was merged in.

jtimpe commented 1 month ago

@ADPennington should be fixed!

ADPennington commented 1 month ago

@jtimpe @victoriaatraft -- quick question -- was the design mockup here intended for this ticket or a follow-on?

jtimpe commented 1 month ago

@jtimpe @victoriaatraft -- quick question -- was the design mockup here intended for this ticket or a follow-on?

@ADPennington it was, but per this comment i modified the template to display a list of stuck files rather than a singular.

ADPennington commented 1 month ago

@jtimpe @victoriaatraft -- quick question -- was the design mockup here intended for this ticket or a follow-on?

@ADPennington it was, but per this comment i modified the template to display a list of stuck files rather than a singular.

ahh thank you! Appreciate the reference @jtimpe

ADPennington commented 1 month ago

testing update: