Closed jtimpe closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 92.66%. Comparing base (
c15cb7c
) to head (1f6756b
). Report is 2 commits behind head on develop.
@jtimpe some unit tests are failing on this branch since the reparsing work was merged in.
@ADPennington should be fixed!
@jtimpe @victoriaatraft -- quick question -- was the design mockup here intended for this ticket or a follow-on?
@jtimpe @victoriaatraft -- quick question -- was the design mockup here intended for this ticket or a follow-on?
@ADPennington it was, but per this comment i modified the template to display a list of stuck files rather than a singular.
@jtimpe @victoriaatraft -- quick question -- was the design mockup here intended for this ticket or a follow-on?
@ADPennington it was, but per this comment i modified the template to display a list of stuck files rather than a singular.
ahh thank you! Appreciate the reference @jtimpe
testing update:
Summary of Changes
Pull request closes #2990
How to Test
SENDGRID_API_KEY
env var is set, reach out if you need a valid keyOFA System Admin
shell_plus
, change thecreated_at
to >1hr ago.shell_plus
, change thetimeout_at
to some time in the past. Changefinished
andsuccess
toFalse
.docker compose exec web python manage.py find_pending_submissions
.Try a lot of combinations. If you can get it to fire in real life stuck-file scenarios, that's a plus.
Example of email
Deliverables
More details on how deliverables herein are assessed included here.
Deliverable 1: Accepted Features
Checklist of ACs:
lfrohlich
and/oradpennington
confirmed that ACs are met.Deliverable 2: Tested Code
CodeCov Report
comment in PR)CodeCov Report
comment in PR)Deliverable 3: Properly Styled Code
Deliverable 4: Accessible
iamjolly
andttran-hub
using Accessibility Insights reveal any errors introduced in this PR?Deliverable 5: Deployed
Deliverable 6: Documented
Deliverable 7: Secure
Deliverable 8: User Research
Research product(s) clearly articulate(s):