pip install --user should use "pip3" when available

raghur / vim-ghost

Vim/Nvim client for GhostText - Edit browser text areas in Vim/Neovim

333 stars 13 forks source link

pip install --user should use "pip3" when available #10

Closed EricR86 closed 6 years ago

EricR86 commented 6 years ago

This is a minor environment issue but for users who have to manage both version of python on their system (say an old Python 2 system install for yum, etc), using pip3 if it is available would seem like a better choice when attempting to install the requirements. 'pip' may alias by default to the python 2 version.

raghur commented 6 years ago

So the install script uses https://github.com/raghur/vim-ghost/blob/5dc053ba72deaa78f34a894d5a39478ee53b166e/install#L2

Basically if python3 exists, it uses the pip corresponding to whatever version of python3 is being used by nvim. I earlier had pip3 but this ran into issues where there might be multiple python3 versions around and pip pointing to a different one from whatever is python3 version under nvim. See https://github.com/raghur/vim-ghost/issues/6#issuecomment-371043021

EricR86 commented 6 years ago

My mistake. I did have an issue with :GhostInstall not installing the dependencies though and now I have no idea what caused it. I assumed it was because of the 'pip' command mentioned on the README.