search

rahulharpal1603 / CF-TopHacker

Chrome extension for displaying Hacks leaderboard on CF.
https://chromewebstore.google.com/detail/cf-tophacker/jjonaiodlgelhegbbihodicniiccbhbi
4 stars 10 forks source link

feat (add-pagination) #21

Closed ShashankAG25 closed 1 week ago

ShashankAG25 commented 1 month ago

Issue #20 : Added pagination to user listing, per page limit 100.

Screenshot from 2024-10-26 18-11-58 Screenshot from 2024-10-26 18-12-18 Screenshot from 2024-10-26 18-12-29 Screenshot from 2024-10-26 18-12-39

rahulharpal1603 commented 1 month ago

Hi @ShashankAG25, Thank you for the PR! I have some suggestions before we can merge this. Please don't re-fetch all the contest data just to display the next page. It will cause unnecessary overheads, and we want our extension to be fast and snappy. I would recommend making changes so that we need to fetch only once.

rahulharpal1603 commented 1 month ago

Hi @ShashankAG25, Thank you for the PR! I have some suggestions before we can merge this. Please don't re-fetch all the contest data just to display the next page. It will cause unnecessary overheads, and we want our extension to be fast and snappy. I would recommend making changes so that we need to fetch only once.

Also, the last row, which displays total hacks, should be the overall totals, just like the codeforces standings page. Regardless of what page we are on, the last row should always display the overall total.

ShashankAG25 commented 3 weeks ago

Hi @rahulharpal1603 ,

Thank you for your feedback! I appreciate your suggestions. I have made the necessary changes to ensure that we fetch the contest data only once, which should improve the performance of the extension. Also made changes to the Total hacks data . Looking forward to your review!

rahulharpal1603 commented 1 week ago

Thank you @ShashankAG25 !