search

rails / devcontainer

MIT License
63 stars 19 forks source link

[Proposal] Create `bun` devcontainer feature #21

Closed duduribeiro closed 7 months ago

duduribeiro commented 7 months ago

This commit creates a new feature that will install bun in a devcontainer.

https://github.com/rails/rails/pull/51520 this PR adds node to rails devcontainer.json generated file if node is required. I thought on add the same for bun if using bun so I thought that would be better to create a devcontainer feature for it instead of adding it to Dockerfile. Wdyt?

The default version 1.0.1 is the same added on rails app https://github.com/rails/rails/blob/64fadc6ffe2cdb9c3fe5e880a49356d3d3a19e2d/railties/lib/rails/generators/app_base.rb#L20

rafaelfranca commented 7 months ago

Thank you for the pull request. Can you propose the feature to https://github.com/devcontainers/features instead? This benefits more than the Rails community.

duduribeiro commented 7 months ago

https://github.com/devcontainers/features/pull/949 lets see 😄