Closed mxie closed 10 years ago
@conchan When you get a chance, could you see if maybe there's any fixing we could do to make the form look better?
Currently, it's a straight-up "copy-and-paste" from MailChimp:
I think we can do without some of the classes and ID's they included in the form.
Hmm.. Do we need the "Email Format" dealio? I ain't never seen that before on quick newsletter signup forms
Nah, I don't think we really need it. Though it is shown on the usual form we link to. The names might still be nice to have though. On Aug 17, 2014 4:37 PM, "Connie Chan" notifications@github.com wrote:
Hmm.. Do we need the "Email Format" dealio? I ain't never seen that before on quick newsletter signup forms
— Reply to this email directly or view it on GitHub https://github.com/railsbridge-boston/website/pull/12#issuecomment-52439410 .
I went ahead and removed the "Email format" option. I'm down with getting their names if you think it's a good idea, though can we get Mailchimp to combine first and last so they're not 2 different fields?
Oh oops, I had that change in my branch somewhere but never pushed it up...my bad. Removing email format is fine. Not sure about combining the two name fields though only because I'm not sure how it'll affect existing members of the list. I'll look into this!
Instead of combining the fields, I just removed the last name field entirely since we're not really using it in our emails anyway. I've also removed some of the id/class attribute stuff that MailChimp automatically included.
Are there any things you wanted to do with this before review/merging?
I think that should be good then! Styles should already be ready
-- Connie www.connie.cc
On August 29, 2014 at 11:17:00 AM, Melissa Xie (notifications@github.com) wrote:
Instead of combining the fields, I just removed the last name field entirely since we're not really using it in our emails anyway. I've also removed some of the id/class attribute stuff that MailChimp automatically included.
Are there any things you wanted to do with this before review/merging?
— Reply to this email directly or view it on GitHub.