rainbow-me / browser-extension

An Ethereum wallet built for speed 🌈
https://rainbow.me/
GNU General Public License v3.0
170 stars 40 forks source link

ledger clear signing upgrades #1645

Closed DanielSinclair closed 2 months ago

DanielSinclair commented 4 months ago

Fixes BX-#### Figma link (if any):

What changed (plus any additional context for devs)

Follow ups

Screen recordings / screenshots

What to test

socket-security[bot] commented 4 months ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@ledgerhq/cryptoassets@13.3.0 None 0 62 MB ldg-github-ci
npm/@ledgerhq/devices@8.4.2 None 0 222 kB ldg-github-ci
npm/@ledgerhq/domain-service@1.2.3 None 0 142 kB ldg-github-ci
npm/@ledgerhq/errors@6.18.0 None 0 205 kB ldg-github-ci
npm/@ledgerhq/evm-tools@1.2.0 None 0 131 kB ldg-github-ci
npm/@ledgerhq/hw-app-eth@6.38.0 None 0 2.16 MB ldg-github-ci
npm/@ledgerhq/hw-transport-mocker@6.29.2 None 0 107 kB ldg-github-ci
npm/@ledgerhq/hw-transport-webhid@6.29.2 None 0 74.3 kB ldg-github-ci
npm/@ledgerhq/hw-transport@6.31.2 None 0 132 kB ldg-github-ci
npm/@ledgerhq/live-env@2.2.0 None 0 262 kB ldg-github-ci
npm/@ledgerhq/types-live@6.50.0 None 0 372 kB ldg-github-ci

🚮 Removed packages: npm/@ledgerhq/cryptoassets@11.4.0, npm/@ledgerhq/devices@8.2.0, npm/@ledgerhq/domain-service@1.1.17, npm/@ledgerhq/errors@6.16.1, npm/@ledgerhq/evm-tools@1.0.14, npm/@ledgerhq/hw-app-eth@6.35.3, npm/@ledgerhq/hw-transport-mocker@6.28.2, npm/@ledgerhq/hw-transport-webhid@6.28.2, npm/@ledgerhq/hw-transport@6.30.2, npm/@ledgerhq/live-env@0.9.0, npm/@ledgerhq/live-network@1.1.11, npm/@ledgerhq/live-promise@0.0.3, npm/@ledgerhq/types-live@6.44.0, npm/lru-cache@7.18.3

View full report↗︎

github-actions[bot] commented 4 months ago

Here's the packed extension for this build: rainbowbx-2670aab407ab027138eef8761ddd3a7f41e52519

github-actions[bot] commented 4 months ago

Here's the packed extension for this build: node_modules.tar.gz rainbowbx-661b1371eef876b0b655d7a481a0f84298449e35

github-actions[bot] commented 4 months ago

Here's the packed extension for this build: node_modules.tar.gz rainbowbx-661b1371eef876b0b655d7a481a0f84298449e35

BrodyHughes commented 4 months ago

Tried a swap and got stuck here:

Screenshot 2024-07-31 at 1 42 51 PM

Tried a send and got stuck after hitting the send action button. Will dm u the console logs.

github-actions[bot] commented 4 months ago

Here's the packed extension for this build: node_modules.tar.gz rainbowbx-5064422db113513c824a15a95ed57c2826688051 screenshots

DanielSinclair commented 3 months ago

Moving to draft until we make progress with Ledger SDK issues