search

rainbow-me / rainbow

🌈‒ the Ethereum wallet that lives in your pocket
https://rainbow.me
GNU General Public License v3.0
3.96k stars 630 forks source link

omit certain defi positions from users wallet balance #6103

Closed greg-schrammel closed 2 months ago

greg-schrammel commented 2 months ago

Fixes APP-####

What changed (plus any additional context for devs)

uses BE omit_from_total tag to ignore adding certain positions value into the users total wallet balance

Screen recordings / screenshots

before/after ~note: Im looking into that first token in the list ($125.73) not being accounted~(it was BE wayne fixed it 🎉)

Screenshot 2024-09-13 at 16 40 41 Screenshot 2024-09-13 at 16 41 56 Screenshot 2024-09-13 at 16 42 15

What to test

linear[bot] commented 2 months ago

APP-1840 Don't count defi positions where `omit_from_total` is true towards a user's portfolio value

brunobar79 commented 2 months ago

Launch in simulator or device for 506756aa16a8c4f1c01a16637c894a53b0ae6130

brunobar79 commented 2 months ago

Can you add PoW & Testing instructions? @greg-schrammel