rainbow-me / rainbow

🌈‒ the Ethereum wallet that lives in your pocket
https://rainbow.me
GNU General Public License v3.0
3.96k stars 630 forks source link

[CHORE]: Remove transaction inconsistencies and improve type safety #6137

Closed walmat closed 1 month ago

walmat commented 2 months ago

What changed (plus any additional context for devs)

This PR cleans up a lot of the unused code stemming back from the transaction redux => Zustand refactor. A lot of our types were duplicated and all over the place. Now they all are in @/entities/transactions/... and can be referenced via @/entities.

I also coupled this PR with cleaning up the ProfileScreen => ActivityList since it's touching 100% of the transactions code. Noticed lots of things once converting those two files to typescript.

Note there are still a bit of casts as in this PR that I want to create smaller follow-up PRs for

Screen recordings / screenshots

https://github.com/user-attachments/assets/69989bba-6e24-43ea-9bfd-b95a3839dd88

What to test

All things transactions

socket-security[bot] commented 1 month ago

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@types/react-native-indicators@0.16.6 None 0 7.64 kB types

View full report↗︎

brunobar79 commented 1 month ago

Launch in simulator or device for 43d4fad9b42a319e067d23e7499e5a131b2376f4

brunobar79 commented 1 month ago

Launch in simulator or device for 38882f5ba863712614d4b571fd2a7e6d365c19c8

brunobar79 commented 1 month ago

Launch in simulator or device for 87d143f00221dffa221ffec6a2a8ac18e979baa6

brunobar79 commented 1 month ago

Launch in simulator or device for 70f47551ab624c95cbb54e0d325901f0b6de010f

brunobar79 commented 1 month ago

Launch in simulator or device for fe1be150951b75bf68ea68191aad38a72ca46aca

brunobar79 commented 1 month ago

Launch in simulator or device for f1a41dbfdfea74b245b9ad8ce78506e95c93d905