Claim bug fix - Githubissues

benisgold commented 1 month ago

Fixes APP-1918

What changed (plus any additional context for devs)

The problem: Grant enabled claimables on TF, and then downloaded prod. He then claimed a few claimables. The claims were successful, however the claimables data displayed on the wallet screen failed to update, and never updated even after a day of waiting and restarting the app.

Why it happened: The way feature flags are accessed on the wallet screen is different than everywhere else in the app, which can cause partial enablement of features when switching from TF to prod. This is what happened with claimables. The claimables feature SHOULD have been automatically disabled when switching to prod, however it was still enabled on the wallet screen while the claimables query was disabled (which caused the data on the wallet screen to never update).

The solution: I fixed the way feature flags values are accessed on the wallet screen. This change guarantees that in prod the feature flag values will always be the default ones, not the ones leftover from TF. Other changes:

added a query refetchInterval of 2 min
immediately remove a claimable from the query data if the claim was successful
invalidate (and refetch) claimables query data 20s after claim functionality completes, regardless of outcome. this will repopulate a claimable if incorrectly removed, or remove a claimable if it was incorrectly displayed (which may have led to a failed claim outcome)