Remove direct usage of web3Provider - Githubissues

rainbow-me / rainbow

🌈‒ the Ethereum wallet that lives in your pocket

https://rainbow.me

GNU General Public License v3.0

3.95k stars 627 forks source link

Remove direct usage of web3Provider #6200

Closed jinchung closed 1 month ago

jinchung commented 1 month ago

Fixes APP-1925

What changed (plus any additional context for devs)

As part of removing the direct import and usage of web3Provider, I made some functions require a mandatory provider param
Moved over to using the getProvider function

Screen recordings / screenshots

Sending: https://github.com/user-attachments/assets/9448ddff-7413-43c2-847b-3075125599e7

Offline toast: https://github.com/user-attachments/assets/b361229c-65f8-434f-b96e-c795cf3cab76

What to test

sending on various networks
executing swap transactions on various networks
WalletConnect transactions and message signing
speed up and cancel txns across various networks
check OfflineToast behaves as expected
updating Showcase behaves as expected

linear[bot] commented 1 month ago

APP-1925 Remove all direct imports and usage of web3Provider

brunobar79 commented 1 month ago

Launch in simulator or device for f3334eb36b7b68301037a76de62fdfe4c52d1f6d

brunobar79 commented 1 month ago

Launch in simulator or device for afec91fdbe750685be4aff0148581df065cc19ff