Fix approval + swaps - Githubissues

brunobar79 commented 2 weeks ago

Fixes APP-2023 Fixes APP-2017

What changed (plus any additional context for devs)

Two separate issues:

Supporting permit in a few tokens was conflicting with gas estimation causing different issues, resulting in incorrect gas estimations and onchain failures running out of gas (see ticket 2017)
We have a check that waits for node ack before continuing on to the next rap action; any failure to find the tx (ex. private mempool) would make the rap fail and subsequent actions would never execute (see ticket 2023). Historical context for this node ack in general: https://github.com/rainbow-me/browser-extension/pull/740

Changes:

Disable permit support for now as there are pros and cons to this; we can revisit this separately
Simplifies node ack check to being before any rap action past the first one needs it (means we no longer need to check if there is more than 1 action after the first action; it also means we don't unnecessarily do this check after the last action)
Simplifies the node ack check to only be for non-mainnet transactions
Caps the number of retries for node ack to 10