[BUG] In the last version 6.6.62 shortcut to open extension menubar stopped working in FF

raindropio / app

https://app.raindrop.io

MIT License

964 stars 99 forks source link

[BUG] In the last version 6.6.62 shortcut to open extension menubar stopped working in FF #155

Open natrim opened 1 week ago

natrim commented 1 week ago

Describe the bug In the last version (6.6.62) shortcut to open extension menubar stopped working in FF

To Reproduce Steps to reproduce the behavior:

Go to 'about:addons'
Click on 'Set shortcuts'
You will se that the option to open the Shortcut extension menu has disappeared

FF 132.0.2 (aarch64) MacOS 15.1 Extension v6.6.62

obrazek

in ext version 6.6.24 the option to add shortcut was still here

obrazek

blancpain commented 1 week ago

Noticed this as well - very useful shortcut, would be great if it can be brought back!

natrim commented 1 week ago

happened here: https://github.com/raindropio/app/commit/4d7a9b91b871ccab86ab46c75e0c1fb34b5104a7#diff-a04d69f11d2d98c1da1015be3b71c3ab879c612f0e86d18040ce4916110667ffL130

the removal of _execute_action instead of removing only the suggested_key the whole action got removed

piasnikj commented 4 days ago

Agreed. Not sure why this would be removed.

heyswayam commented 4 days ago

In my case, I’m unable to use the keyboard shortcut to open Raindrop in the sidebar. I tried using a combination of shortcut keys, including the default one (cmd+period), but it doesn’t work. If I set the shortcut, it works until I reopen Firefox. I hope this issue is resolved soon because I’m already frustrated.

Edit: It appears to work in the settings page, but when I try to use the cmd+period on a website, it closes immediately after opening. I tried looking up the debug console, but I did see console.logs in the settings page, but didn't see them in the websites where the shortcut doesn't works.