search

rajat2502 / GitHub-Battle

A simple react app to battle two github users
https://github-battlereact.netlify.com/
GNU General Public License v3.0
15 stars 6 forks source link

Add a personal profile section. #2

Open rajat2502 opened 5 years ago

rajat2502 commented 5 years ago

A personalized section where users can see their contribution graphs and other stats will look good in this project.

dsaharia commented 5 years ago

I want to work on this issue for KWoC 2019. For login I have to use Oauth right? then display information regarding stars, followers etc?

rajat2502 commented 5 years ago

@dsaharia don't include login signup for now, just add a profile link to the navbar and in that component add a input box to enter your profile and then use the GitHub's API to show stats.

rajat2502 commented 5 years ago

For reference about what to show in that component you can have a look at https://github.com/rajat2502/GitHub-Finder this app. Keep showing your progress in small steps so that I can approve and you can work further.

dsaharia commented 5 years ago

Yes, Sure. I'll keep you posted by Email?

rajat2502 commented 5 years ago

Sure!!! but you can also join the Gitter channel from the KWoC website.

rajat2502 commented 4 years ago

Are you working?

dsaharia commented 4 years ago

Yes started today. As you have heard internet is cut in many places in Assam now

Dhiraj Saharia

From: Rajat Verma notifications@github.com Sent: Sunday, December 15, 2019 12:54:10 AM To: rajat2502/GitHub-Battle GitHub-Battle@noreply.github.com Cc: Dhiraj Saharia dsaharia@outlook.com; Assign assign@noreply.github.com Subject: Re: [rajat2502/GitHub-Battle] Add a personal profile section. (#2)

Are you working?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/rajat2502/GitHub-Battle/issues/2?email_source=notifications&email_token=AHB5EFKDHJ2KJX3IV37C6TDQYUXFVA5CNFSM4JSDQNHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEG4JJ2Q#issuecomment-565744874, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHB5EFLKTZ5FQM37BYBG6QLQYUXFVANCNFSM4JSDQNHA.

rajat2502 commented 4 years ago

Ok take your time.

dsaharia commented 4 years ago

Internet is back here. I am working on it... I will create a Profile section and then ask for the username of the user right then show him his stats. Right?

Regards, Dhiraj Saharia, B.Tech, CSE (3rd Year), Tezpur University, Napaam, Assam - 784028

On 15-Dec-2019, at 7:02 AM, Rajat Verma notifications@github.com<mailto:notifications@github.com> wrote:

Ok take your time.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/rajat2502/GitHub-Battle/issues/2?email_source=notifications&email_token=AHB5EFPMRTGNS65RLKG55FLQYWCJRA5CNFSM4JSDQNHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEG4PDMY#issuecomment-565768627, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHB5EFMMNAHKWFQ4TUCKXYTQYWCJRANCNFSM4JSDQNHA.

rajat2502 commented 4 years ago

@dsaharia Yeah that's cool. For showing, loading add a loader. Use the same input button as used in the battle component. Add the profile route to the main navbar

dsaharia commented 4 years ago

I added the route and currently trying to display the results. I have pushed code.. Should I do a PR now ? for my evaluations?

On 17-Dec-2019, at 9:10 PM, Rajat Verma notifications@github.com<mailto:notifications@github.com> wrote:

@dsahariahttps://github.com/dsaharia Yeah that's cool. For showing, loading add a loader. Use the same input button as used in the battle component. Add the profile route to the main navbar

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/rajat2502/GitHub-Battle/issues/2?email_source=notifications&email_token=AHB5EFPKDCXVIIHU5QWQAWDQZDXGHA5CNFSM4JSDQNHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHCZEHQ#issuecomment-566596126, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHB5EFKED6XFYRBGTPBQ6DTQZDXGHANCNFSM4JSDQNHA.

rajat2502 commented 4 years ago

Just show me that by hosting.

dsaharia commented 4 years ago

hosting using netlify and my account?

On 18-Dec-2019, at 8:08 AM, Rajat Verma notifications@github.com<mailto:notifications@github.com> wrote:

Just show me that by hosting.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/rajat2502/GitHub-Battle/issues/2?email_source=notifications&email_token=AHB5EFN2V4C5CEUFW32YXZLQZGEI5A5CNFSM4JSDQNHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHEU2NQ#issuecomment-566840630, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHB5EFLHQHSOMV2KQHSFZQ3QZGEI5ANCNFSM4JSDQNHA.

dsaharia commented 4 years ago

I have some doubts.

  1. The RepoCard component takes data.owner.avatar_url. Why is there owner in between? When I try to use this component for profile section it gives error because there is no owner attribute in the data. What should I do?
rajat2502 commented 4 years ago

Yeah, you can use netlify to host. Well about the owner thing I am not sure, maybe there are some changes in GitHub's API If it's working without owner use it that way.

dsaharia commented 4 years ago

It is working without using the owner. Should I host or send you screenshots of it? Because hosting will take time, and it is already hosted right?

rajat2502 commented 4 years ago

Host your version of website, it's easy try and read about Netlify hosting.

dsaharia commented 4 years ago

I did some changes and added a profile section. It needs UI improvements, working on it. Also hosted it LINK : https://fervent-lamarr-9bf0e5.netlify.com/ How is it?

rajat2502 commented 4 years ago

Well many UI improvements are needed image Also, none of the icons are loading. Please see to it.

dsaharia commented 4 years ago

It is loading in my pc. I have tested it. Please see Screenshot 2019-12-21 at 6 46 37 PM

rajat2502 commented 4 years ago

Not loading!!!

dsaharia commented 4 years ago

It should load. I have tested it in chrome as well as Firefox. Both loading fine.

Neilblaze commented 4 years ago

It should load. I have tested it in chrome as well as Firefox. Both loading fine.

@dsaharia please check issue #11

dsaharia commented 4 years ago

There might be a issue. But I checked in Safari, Chrome and firefox. All the emoji's were loading fine.

dsaharia commented 4 years ago

How can I check, any clues?

rajat2502 commented 4 years ago

Okay try to use any emoji service like fontawesome.

dsaharia commented 4 years ago

Done. Integrated FontAwesome for profile badges. link: https://fervent-lamarr-9bf0e5.netlify.com Should I open a PR now?

rajat2502 commented 4 years ago

Well the profile component needs some better design (the design should match with the design of the rest of the page.) Also, this component should also include some charts and analysis with data. If the work is more I can divide into more than one person. For now, you can just work on the styling of the component. Also, if possible try SVG for icons as font-awesome is a heavy library.

dsaharia commented 4 years ago

Yeah I am currently working on the styling and 1 more person would be good to do the charts and analysis, so that we would discuss it and then do it.

rajat2502 commented 4 years ago

Okay you work on the styling for now.

dsaharia commented 4 years ago

Link: https://fervent-lamarr-9bf0e5.netlify.com

  1. I have added a CSS file to match the profile section to other parts of the site.
  2. Removed the fontawesome library.
  3. Added SVG icons for the profile section. Working fine now. Also compatible with dark mode. Please check. Also I need help with the charts and other analysis.
rajat2502 commented 4 years ago

Please decrease the width of the container that contains the total info.