search

rajatjindal / krew-release-bot

bot to bump version of plugin in krew-index on new releases
Apache License 2.0
46 stars 17 forks source link

maybe remove "without gomodules" examples #16

Closed ahmetb closed 4 years ago

ahmetb commented 4 years ago

Please have a really small example if you can, then just have 1 go example.

Then, for everything else, link to other repos as the examples.

rajatjindal commented 4 years ago

will do this today.

rajatjindal commented 4 years ago

This is done now. Removed the documentation for non-go-modules example. Will be adding more examples this weekend

ahmetb commented 4 years ago

I think you need fewer examples, and more links to other examples. :)

rajatjindal commented 4 years ago

Got it. Will open a few pr for diff plugins to onboard and then will add their examples as links?

On Sat, Jan 18, 2020 at 1:08 AM Ahmet Alp Balkan notifications@github.com wrote:

I think you need fewer examples, and more links to other examples. :)

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/rajatjindal/krew-release-bot/issues/16?email_source=notifications&email_token=AAEVN7BKCJYJJPFLMD5WJNDQ6ICLRA5CNFSM4KGGDTO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJIX7GA#issuecomment-575766424, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEVN7B6MCVXWMAKGEL3JKLQ6ICLRANCNFSM4KGGDTOQ .

-- Rajat Jindal | Pune | https://rajatjindal.com | rajatjindal83@gmail.com