rajatjindal / krew-release-bot

bot to bump version of plugin in krew-index on new releases
Apache License 2.0
46 stars 17 forks source link

Make actions understand previous PRs #19

Closed rikatz closed 3 years ago

rikatz commented 4 years ago

So I've made a mess here with .krew.yaml and needed to release a new version. (https://github.com/kubernetes-sigs/krew-index/pull/444)

But when I've released a newer version, bot got some errors and the previous PR wasn't closed.

/usr/bin/docker run --name rajatjindalkrewreleasebotv0031_794f6a --label 671ee6 --workdir /github/workspace --rm -e GOROOT -e INPUT_WORKDIR -e INPUT_KREW_TEMPLATE_FILE -e HOME -e GITHUB_REF -e GITHUB_SHA -e GITHUB_REPOSITORY -e GITHUB_ACTOR -e GITHUB_WORKFLOW -e GITHUB_HEAD_REF -e GITHUB_BASE_REF -e GITHUB_EVENT_NAME -e GITHUB_WORKSPACE -e GITHUB_ACTION -e GITHUB_EVENT_PATH -e RUNNER_OS -e RUNNER_TOOL_CACHE -e RUNNER_TEMP -e RUNNER_WORKSPACE -e ACTIONS_RUNTIME_URL -e ACTIONS_RUNTIME_TOKEN -e ACTIONS_CACHE_URL -e GITHUB_ACTIONS=true -v "/var/run/docker.sock":"/var/run/docker.sock" -v "/home/runner/work/_temp/_github_home":"/github/home" -v "/home/runner/work/_temp/_github_workflow":"/github/workflow" -v "/home/runner/work/kubepug/kubepug":"/github/workspace" rajatjindal/krew-release-bot:v0.0.31
time="2020-01-19T21:09:39Z" level=info msg="using template file \"/github/workspace/.krew.yaml\""
time="2020-01-19T21:09:39Z" level=info msg="getting sha256 for https://github.com/rikatz/kubepug/releases/download/v0.2.3/kubepug_darwin_amd64.tar.gz"
time="2020-01-19T21:09:40Z" level=info msg="downloaded file /tmp/113529204/1579468179"
time="2020-01-19T21:09:40Z" level=info msg="getting sha256 for https://github.com/rikatz/kubepug/releases/download/v0.2.3/kubepug_linux_amd64.tar.gz"
time="2020-01-19T21:09:40Z" level=info msg="downloaded file /tmp/780636227/1579468180"
time="2020-01-19T21:09:40Z" level=info msg="getting sha256 for https://github.com/rikatz/kubepug/releases/download/v0.2.3/kubepug_windows_amd64.zip"
time="2020-01-19T21:09:40Z" level=info msg="downloaded file /tmp/008821446/1579468180"
time="2020-01-19T21:09:41Z" level=fatal msg="expected status code 200 got 500. body: opening pr: non-fast-forward update: refs/heads/rikatz-kubepug-v0.2.3\n"
##[error]Docker run failed with exit code 1
corneliusweig commented 4 years ago

So far this hasn't been a big problem. But since the release bot creates the PR and not the author who triggered it, the author will never be able to clean up himself.

I don't think this is high prio, but if you find a solution it would be appreciated.

rikatz commented 4 years ago

For sure, I will think in something that might be helpful, as verifying if that author and project have some PR for that same plugin and closing old PRs :)

Thank you!!

Em dom, 19 de jan de 2020 às 18:42, Cornelius Weig notifications@github.com escreveu:

So far this hasn't been a big problem. But since the release bot creates the PRand not the author who triggered it, the author will never be able to clean up himself.

I don't think this is high prio, but if you find a solution it would be appreciated.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rajatjindal/krew-release-bot/issues/19?email_source=notifications&email_token=ABWZQBNDDYNK5J3C4G6PHP3Q6TCOBA5CNFSM4KI3TCWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJK5LZA#issuecomment-576050660, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABWZQBOWZUEIYKEKPY6KA33Q6TCOBANCNFSM4KI3TCWA .

rikatz commented 4 years ago

@corneliusweig PTAL https://github.com/rajatjindal/krew-release-bot/pull/21

Thank you!!

corneliusweig commented 4 years ago

@corneliusweig PTAL #21

Thank you!!

As it's @rajatjindal's repo and idea, he has to review :smile:. But if you need a second opinion, just @-mention me.