Closed rikatz closed 3 years ago
thank you so very much for opening the PR. I will test it out myself once, and publish a new release.
@rajatjindal sorry for the long delay.
So I've made the following:
Let's see if this works :)
I think in general features like these create additional complexity. Unless it works super cleanly, I’d normally be against it.
@ahmetb Let's give it a try. Otherwise, the krew maintainers are the only ones who are allowed to close the PR by the bot.
I think that’s fine. We always do that anyway.
@ahmetb just to make sure we are on same page, are u recommending we do not pursue this PR? I will go ahead with what you/Cornelius agree upon.
I think the search query isn't solid and relies on GitHub's search (which admittedly is pretty bad and isn't an API to be relied on). You might accidentally end up closing other PRs unintended.
If you want to merge, that's fine with me. It'll come at a maintenance cost.
Another, maybe simpler, approach is this:
krew-release-bot
fork.krew-index
by krew-release-bot
That way, there is no need to close old PRs at all. WDYT?
I think this is straight forward enough for now. and only author can close the PR, so it won't close the other PR's.
and also because its server side, if needed, we can push a fix for any issue discovered at a later stage.
thanks Rajat Jindal
@rajatjindal sorry, I've been digging into other stuff and completely forgot this PR.
Do you still want me to move forward with this feature? There's a final change requested to make a warning instead of an error when not being able to close outdated PRs, I can do this easily :) Just let me know.
Thank you!
Yes please. Its been waiting for you. Thank you for following up
On Thu, Apr 2, 2020 at 7:30 PM Ricardo Katz notifications@github.com wrote:
@rajatjindal https://github.com/rajatjindal sorry, I've been digging into other stuff and completely forgot this PR.
Do you still want me to move forward with this feature? There's a final change requested to make a warning instead of an error when not being able to close outdated PRs, I can do this easily :) Just let me know.
Thank you!
— You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/rajatjindal/krew-release-bot/pull/21#issuecomment-607864678, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEVN7HYK7JLMICT7BSGU2DRKSLBDANCNFSM4KJKT3FA .
-- Rajat Jindal | Pune | https://rajatjindal.com | rajatjindal83@gmail.com
@rajatjindal so I've made the last change :) please let me know if there's anything else I can do.
Thank you!
Signed-off-by: Ricardo Pchevuzinske Katz ricardo.katz@gmail.com
This PR is to Close outdated PRs that might be stuck before opening new ones
I didn't tested it in prod, as I actually don't know how to trigger an action to check if its working
Fixes: #19