rajatjindal / krew-release-bot

bot to bump version of plugin in krew-index on new releases
Apache License 2.0
46 stars 16 forks source link

Support custom krew index #47

Open tamalsaha opened 3 years ago

tamalsaha commented 3 years ago

Thanks for this bot. We are looking to use this bot with our hosted custom plugin index. ref: https://krew.sigs.k8s.io/docs/developer-guide/custom-indexes/

Is that possible? If not, could that be supported?

rajatjindal commented 3 years ago

hey @tamalsaha , thanks for reaching out. I follow/admire your work on a lot of kubernetes related projects, so it means a lot to hear from you.

the custom index support should be already supported (you can override the default krew-index org/repo using env variables). could you please try that once?

also seems like the url you provided is not for the custom krew-index right?

in the meantime, i would give this a try too, and revert back.

rajatjindal commented 3 years ago

ok, i looked at the code, its on server side where u can use env variable to override the krew-index org/repo. I will explore making change to be able to override them from client side (github-action), and report back.

tamalsaha commented 3 years ago

Thanks for the kind words, @rajatjindal ! This work also looks very impressive.

We have decided to extend our existing release automation process to also update the krew manifest, instead of using this action. I did use your idea to use a krew.yaml template. Sorry taking up your time.

rajatjindal commented 3 years ago

Sure, thanks.

I will keep this ticket open to add the support incase anyone else needs that in future

Thanks again

ArtemTrofimushkin commented 1 year ago

hello @rajatjindal ! is there any updates on this issue?

rajatjindal commented 1 year ago

Hi @ArtemTrofimushkin

I haven't had chance to look at this yet. I will try to spend some time on this next week. (or may be you can submit as a PR?)

thanks

ArtemTrofimushkin commented 1 year ago

Thanks! I will submit PR in a few days!

ankishagarwal commented 1 year ago

@ArtemTrofimushkin Were you able to work on this ?