search

rajatomar788 / pywebcopy

Locally saves webpages to your hard disk with images, css, js & links as is.
https://rajatomar788.github.io/pywebcopy/
Other
520 stars 105 forks source link

Fix for handling href tel: element in parse_url() urls.py #100

Closed serbathome closed 2 years ago

serbathome commented 2 years ago

Added condition to check if url contains tel: and ignoring it by returning empty url. Not ideal solution, but works for me a quick and dirty fix to make copy work for sites containing new phone elements.

rajatomar788 commented 2 years ago

OK it's done.

rajatomar788 commented 2 years ago

Please note that the changes might not reflect at pypi for some time.

rajatomar788 commented 1 year ago

Hey, I know its late but I merged this PR in a hurry without realizing that their already existed a fix within the code. So hope you don't mind but I have to label this PR as an invalid.

yashttm commented 1 year ago

What was the fix @rajatomar788 ? The issue still persists it seems. @serbathome 's solutions works well.

rajatomar788 commented 1 year ago

The tel: is a schema so there exists a way so to block invalid schemas such as javascript: etc. So tel: would be added to that block list.