rajatomar788 / pywebcopy

Locally saves webpages to your hard disk with images, css, js & links as is.
https://rajatomar788.github.io/pywebcopy/
Other
520 stars 105 forks source link

Fails on tel links #107

Closed totalhack closed 1 year ago

totalhack commented 1 year ago

It's trying to parse telephone links as html page/resource links.

lib/python3.9/site-packages/pywebcopy/urls.py", line 231, in parse_url
    raise LocationParseError(url)
pywebcopy.urls.LocationParseError: tel:+[REDACTED]
rajatomar788 commented 1 year ago

It should not fail as there was a patch on github sometimes back. Have you tried using the code from github?

totalhack commented 1 year ago

I used the latest version from pip. Should that not have the patch?

On Sun, Feb 26, 2023, 12:59 AM Raja Tomar @.***> wrote:

It should not fail as there was a patch on github sometimes back. Jave you tried using the code from github?

— Reply to this email directly, view it on GitHub https://github.com/rajatomar788/pywebcopy/issues/107#issuecomment-1445275783, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKNI2RER3VQVQRIH2HDB3HDWZLWN7ANCNFSM6AAAAAAVHBQINE . You are receiving this because you authored the thread.Message ID: @.***>

totalhack commented 1 year ago

The latest release in git is 7.0.1, I have 7.0.2. Does that not have the fix?

rajatomar788 commented 1 year ago

No, but I should release a patch tommorow

totalhack commented 1 year ago

I see you merged a fix -- do you plan on pushing a new version to pip?

rajatomar788 commented 1 year ago

I am afraid I won't be able to do it any time soon.

On Thu, 2 Mar, 2023, 7:42 pm totalhack, @.***> wrote:

I see you merged a fix -- do you plan on pushing a new version to pip?

— Reply to this email directly, view it on GitHub https://github.com/rajatomar788/pywebcopy/issues/107#issuecomment-1451931580, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIGSNTWRXAIOPKEW3MZWKTTW2CTFLANCNFSM6AAAAAAVHBQINE . You are receiving this because you commented.Message ID: @.***>