adds ability to toggle multithreading

rajatomar788 / pywebcopy

Locally saves webpages to your hard disk with images, css, js & links as is.

https://rajatomar788.github.io/pywebcopy/

Other

520 stars 105 forks source link

adds ability to toggle multithreading #78

Closed gravelcycles closed 2 years ago

gravelcycles commented 3 years ago

Multiple users have reported that multithreading can be buggy. This PR disables multithreading by default.

rajatomar788 commented 3 years ago

Why is it failing page saving tests?

rajatomar788 commented 3 years ago

Please resolve conflicts

gravelcycles commented 3 years ago

@rajatomar788 apologies. I believe I shared the PR before tests completed running.

gravelcycles commented 3 years ago

@rajatomar788 hmm the tests are failing locally too on master

rajatomar788 commented 2 years ago

With version 7 you can enable or disable multithreading easily. So I guess it settles the debate with a note that you should always set the thread join timeout value otherwise it will hang just like previously.