search

rajatomar788 / pywebcopy

Locally saves webpages to your hard disk with images, css, js & links as is.
https://rajatomar788.github.io/pywebcopy/
Other
520 stars 105 forks source link

AttributeError: 'tuple' object attribute '__doc__' is read-only #91

Open atmaniak opened 2 years ago

atmaniak commented 2 years ago

With the latest release (7.0.1) i get this error message when trying examples from documentation.

I'm using Python 3.9.7

File "**/lib/python3.9/site-packages/pywebcopy/elements.py", line 234, in GenericResource html_content_types.__doc__ = "Set of valid html mimetypes." AttributeError: 'tuple' object attribute '__doc__' is read-only

rajatomar788 commented 2 years ago

Did you try running the tests or on different python versions?

atmaniak commented 2 years ago

Yes, i have the same errors with the tests.

Tested with python 3.8, 3.9 and 3.10 (using docker)

atmaniak commented 2 years ago

Seems like the same error is happening on Github actions and the error is not correctly reported :(

https://github.com/rajatomar788/pywebcopy/runs/4058464007?check_suite_focus=true

rajatomar788 commented 2 years ago

The error seems to be suppressed in the github workflows. So I guess I have to pull the version 7.0.1 for now.

ezzra commented 2 years ago

as the error is happening with 7.0.1, what version should I use to make it work?

rajatomar788 commented 2 years ago

Hey you can use the version on the pypi as it doesn't have any error. Or if you can use the github repo then go to this https://github.com/rajatomar788/pywebcopy7

It has the error fixed by a patch.