search

raku-community-modules / DBIish

Database interface for Raku
89 stars 31 forks source link

Failure to self manage statement handles causes DBDish::Oracle: Error: ORA-01000: maximum open cursors exceeded #210

Closed ancientwizard closed 3 years ago

ancientwizard commented 3 years ago

Built-in operation automations such as ".do", ".execute", ".commit", ".rollback" and perhaps others fail to clean up handles they create and use causing Oracle to run out of cursors over time. Keep in mind the fix for this issue also requires the fixes for issue #209 which makes .dispose on statement handles successfully release.

ancientwizard commented 3 years ago

I've patched this issue; but as I mentioned the complete solution requires the fix for #209 as well otherwise the newly added caching and .dispose method calling will be fruitless.

jonathanstowe commented 3 years ago

Please make a PR.

raiph commented 3 years ago

Hi @ancientwizard,

I noticed your response to "Any chance that you could create a pull request?"](https://github.com/raku-community-modules/DBIish/issues/209#issuecomment-917104262) and have reacted badly to reading @jonathanstowe's comment 'Please make a PR.'. To make myself feel better I just want to write here that I appreciate what I see you've already done, regardless of anything else you might or might not do.

Hi @jonathanstowe,

I've long appreciated all the things I've seen you doing. I have reacted badly to reading your comment 'Please make a PR.', but that's on me, and in my head. I imagine your intent was to politely reassure @ancientwizard a PR would be welcome. And to hope @ancientwizard might feel they would get some joy from doing a PR. However, I'm concerned that @ancientwizard may not yet have felt heard about their prior experience with PRs related to this module; I've learned that reassurance ahead of empathy generally backfires very badly, so I'm super anxious about that. To try make myself feel better I felt compelled to write this comment. I hope you hear that I appreciate the myriad things I've seen you do for years now, and find your ever positive and fun tone inspiring, and dearly hope that you will be OK with me expressing myself. I'm 61 but have only just discovered an explanation for anxieties I've had my whole life. This comment is an experiment in trying to healthily confront that anxiety. I apologize for my verbosity and intrusion but hope you understand. <3

jonathanstowe commented 3 years ago

@raiph you're cool chief :+1:

@ancientwizard It may have been more helpful if I had added more explanation. There is probably a small handful of people who would be confident in reviewing work on the Oracle driver and I wouldn't consider myself amongst those (I've got changes in it related to the original merge but that's it.) No-one is likely to want to merge anything without there having been a couple of eyes on it first. Without a pull request the changes don't have any proper visibility to anyone who may have any input to make, and if someone wants to make a review of the code they would need to pull your branch and examine the diff, if they wish to make some feedback or request some changes then there wouldn't really be any convenient method of doing so that would relate them to the original changes. Making a pull request means that more people will see the change, review and make feedback and consequently make it more likely that the changes will get merged. Without a PR the only way that the work will get merged is if someone were to do it unilaterally (unlikely,) or if someone else were to create a branch in this repository with the changes and make a PR from that and have it reviewed etc. So please make a PR, the work looks like it would be of benefit and it would be a shame if it were to be overlooked.