search

rakugoteam / Rakugo-Dialogue-System

Inspired by Ren'Py, Rakugo is a project aiming to provide a way to make narrative-based games on Godot easily. Simplify your project, if it is a visual novel, point and click, RPG, interactive text game or many other styles and blends of styles.
https://rakugoteam.github.io
MIT License
222 stars 7 forks source link

Gut, One test class to rule them all #174

Closed theludovyc closed 1 year ago

theludovyc commented 1 year ago

If you look in https://github.com/rakugoteam/Rakugo/blob/main/Test/TestParser/TestAsk/TestAsk.gd, https://github.com/rakugoteam/Rakugo/blob/main/Test/TestParser/TestSay/TestSay.gd, and futur updated tests. You can see lot of similar code.

Like file_base_name, parse_and_execute follow by yield, yield follow by assert_signal, assert_true before do_step, etc...

I propose to mutualize them in a class than extends GutTest, call RakugoTest. I thinked about an autoload script, but for me it looks like less good.

What do you think about it ?

Jeremi360 commented 1 year ago

It sound like a good idea :+1: