ralampay / ann

Artificial Neural Networks implemented in C++
52 stars 21 forks source link

Update backPropagation.cpp #22

Closed shalinsirwani closed 4 years ago

shalinsirwani commented 6 years ago

AT ITERATION colcounter = replace getNumCols with getNumRows , because every layer has only one row , by putting it into iteration does'nt make sense if we put NumCols only then we can equally multiply both matrices

And main Mistake is in checking condition :- if(i == 1) { zActivatedVals = this->layers.at(0)->matrixifyVals(); } else { zActivatedVals = this->layers.at(0)->matrixifyActivatedVals(); }

First condition is ok ,when we are just ahead of our input layer.

But at else condition when we are at some arbitrary hidden or convolution layer it have to point towards its next hidden layer (when we are comming back) but in this file it's always points towards the input layer which is very odd.

SORY IF I AM WRONG.