search

ranaroussi / yfinance

Download market data from Yahoo! Finance's API
https://aroussi.com/post/python-yahoo-finance
Apache License 2.0
14.96k stars 2.45k forks source link

Fix 404 Error for Holders #1908

Closed vittoboa closed 7 months ago

vittoboa commented 7 months ago

Fix for the issue #1904, the ticker symbol has been moved from the parameters to the end of the base URL.

sshcli commented 7 months ago

Thanks @vittoboa for the fix

@ValueRaider we need your superpowers, please help us with the review and merge for this PR, and the release of 0.2.38.

Thanks in advance

Mates that will be grateful with you: @EthanW33 @farbodbahari @melgazar9 @hectoorperezz @vittoboa @sshcli

ValueRaider commented 7 months ago

This can merge straight into main branch

Exception: urgent bug-fixes can go straight into main, because presumably main is broken anyway. #1084

(I'll rephrase this)

Also dev has some other changes I don't want to force on users.

Rebase instructions in #1084

vittoboa commented 7 months ago

Rebased :+1:

sshcli commented 7 months ago

Just Perfect! Many thanks @ValueRaider @vittoboa