rancher / dartboard

Code, instructions and results for scalability and performance tests on the Rancher product family
BSD 3-Clause "New" or "Revised" License
3 stars 6 forks source link

[RFE] Enable "BYO" VPC functionality for AWS module #21

Open git-ival opened 2 weeks ago

git-ival commented 2 weeks ago

Currently, the aws_network module creates a new VPC on each apply. This behavior works well for most usecases, but is not ideal because the default VPC limit per account is 5. It would be ideal to be able to pass in a VPC ID or name in order to utilize an existing VPC, instead of forcing creation of a new VPC.

Suggestion: Add an optional input var for VPC ID and set a count on any and all relevant aws_network module resources/datasources. Alternatively, create a separate "byo" module to handle this usecase and set a count on both the aws_network and "byo" modules.

Notes:

moio commented 1 week ago

Totally agreed