rancher / hosted-providers-e2e

Apache License 2.0
0 stars 4 forks source link

Fix GetK8sVersion for all the hosted providers #156

Closed valaparthvi closed 2 months ago

valaparthvi commented 2 months ago

What does this PR do?

  1. Simplify GetK8sVersion for all the hosted providers to call list single variants of each minor version and return a version based on forUpgrade parameter.
  2. Rename AKS ListSingleVariantAKSAvailableVersions to ListSingleVariantAKSAllVersions, also modify it to return the versions in descending order 1.28.3, 1.28.0, etc, and modify the tests using this function with required changes.

Which issue(s) this PR fixes (optional, in fixes #(, fixes #, ...) format, will close the issue(s) when PR gets merged):

Fixes #147

Checklist:

Special notes for your reviewer:

cpinjani commented 2 months ago

Changes looks fine, for 2.9 please also run P0, SupportMatrix

valaparthvi commented 2 months ago

Changes looks fine, for 2.9 please also run P0, SupportMatrix

  1. GKE P0/Support Matrix šŸŸ¢ (import k8s upgrade is re-run) - https://github.com/rancher/hosted-providers-e2e/actions/runs/10593165181/job/29354275476
  2. GKE P0 Import re-run :green_circle: - https://github.com/rancher/hosted-providers-e2e/actions/runs/10597550011
  3. EKS P0/Support Matrix šŸŸ¢ - https://github.com/rancher/hosted-providers-e2e/actions/runs/10593162397/job/29354269851
  4. AKS P0/Support Matrix šŸŸ¢ (Failure with 1.27.16 is also reproducible manually and looks like a temporary failure) - https://github.com/rancher/hosted-providers-e2e/actions/runs/10593159634/job/29354269902
cpinjani commented 2 months ago

Changes looks fine, for 2.9 please also run P0, SupportMatrix

  1. GKE P0/Support Matrix šŸŸ¢ (import k8s upgrade is re-run) - https://github.com/rancher/hosted-providers-e2e/actions/runs/10593165181/job/29354275476
  2. GKE P0 Import re-run šŸŸ¢ - https://github.com/rancher/hosted-providers-e2e/actions/runs/10597550011
  3. EKS P0/Support Matrix šŸŸ¢ - https://github.com/rancher/hosted-providers-e2e/actions/runs/10593162397/job/29354269851
  4. AKS P0/Support Matrix šŸŸ¢ (Failure with 1.27.16 is also reproducible manually and looks like a temporary failure) - https://github.com/rancher/hosted-providers-e2e/actions/runs/10593159634/job/29354269902

JFYI, auto-aks-hp-ci-gcqfz is on version 1.27.16 which is not supported in this region

valaparthvi commented 2 months ago

JFYI, auto-aks-hp-ci-gcqfz is on version 1.27.16 which is not supported in this region

I was able to reproduce it manually on Rancher and Azure console. Even though 1.27.16 is visible on Azure console and rancher, I was not able to create the cluster.