Don't use SSH for AKS nodes

thehejik commented 1 month ago

What does this PR do?

After bumping azure-cli on our runner template I noticed that there is a problem with creating ssh keys via az aks create ... --generate-ssh-keys command.

I believe the problem is concurrency when ginkgo is trying to provision two clusters in parallel and then two az aks create commands are trying to write a new SSH keypair at the same time which leads to this error in CI:

~So trying to add a random sleep <0-2s> to prevent this.~ Final solution is to replace --generate-ssh-key by --no-ssh-key flag as we don't need SSH access to nodes.

Checklist:

[ ] Squashed commits into logical changes
[ ] Documentation
[x] GitHub Actions (if applicable) AKS p0_import https://github.com/rancher/hosted-providers-e2e/actions/runs/11234381541

Special notes for your reviewer:

thehejik commented 1 month ago

It keeps failing, I have to find another way.

valaparthvi commented 1 month ago

What if we create the folder beforehand in BeforeSuite or something?

It keeps failing, I have to find another way.

thehejik commented 1 month ago

In the end I removed the random delay and used --no-ssh-key flag instead of --generate-ssh-key. It seems to work.

rancher / hosted-providers-e2e