randallknutson / redux-injector

Allows dynamically injecting reducers into a redux store at runtime
59 stars 14 forks source link

Do not add injectedReducers property to a store #12

Open xprazak2 opened 6 years ago

xprazak2 commented 6 years ago

Adding the injectedReducers property to a store can cause problems when testing connected components using snapshots.

When adding a new reducer, each snapshots will need to be regenerated because the injectedReducers property on injected store changes. This will become painful as an application grows.

If we want to expose the injectedReducers to the outside world, I can add a function to a store that does it for us.

Let me know what you think.

ares commented 6 years ago

what's the status here?

xprazak2 commented 6 years ago

waiting for review

ares commented 6 years ago

@randallknutson would you mind taking a look?