search

randombit / botan

Cryptography Toolkit
https://botan.randombit.net
BSD 2-Clause "Simplified" License
2.6k stars 570 forks source link

Deprecate 0xFE30 X25519/Kyber512 code point #4347

Closed reneme closed 1 month ago

reneme commented 2 months ago

This code point falls into the 'private code point' region (RFC 8446 4.2.3) and was used by pq.cloudflareresearch.com for hybrid key exchange using X25519+KyberR3-512.

By disabling this code point in test_cli.py [...] pqc_hybrid_tests it should fix the currently failing nightly build.

We plan to provide support for X25519+ML-KEM-768 as well as secp256r1+ML-KEM-768 (draft-kwiatkowski-tls-ecdhe-mlkem-02) soon after #3893 is merged.

coveralls commented 2 months ago

Coverage Status

coverage: 91.281% (+0.002%) from 91.279% when pulling b5df358ceda60e8973a6b00fe2720d575db6400a on reneme:chore/retire_0xFE30 into 0639e821247e61b186c52fbe315dbb0fa5dd4fa6 on randombit:master.

reneme commented 2 months ago

Todo: CI failure is relevant, I believe.

reneme commented 1 month ago

Todo: CI failure is relevant, I believe.

In is_pqc_hybrid() we're using the deprecated enum value in a public header. The method is marked constexpr and I therefore don't want to move its implementation into the compilation unit. Hence, the 'ignore deprecation' macro. 😞

reneme commented 1 month ago

image

🥳