randombit / botan

Cryptography Toolkit
https://botan.randombit.net
BSD 2-Clause "Simplified" License
2.6k stars 570 forks source link

Allow using `secure_allocator` for enum types, like `std::byte` #4353

Closed Delta-dev-99 closed 1 month ago

Delta-dev-99 commented 1 month ago

This is a small change aimed to allow the ussage of std::secure_vector<std::byte>. Enum types are POD so this shouldn't cause problems. I don't see the advantage of allowing enums other than std::byte, but including another header just for this purpose seems unwarranted.

randombit commented 1 month ago

Seems fine to me, @reneme do you see an issue here?

coveralls commented 1 month ago

Coverage Status

coverage: 91.28%. remained the same when pulling 4890fc9fab559b437b66e1c5bcee34859d9fd9ce on Delta-dev-99:patch-1 into 7f256a0afe514aa15fee594e0d5e30d2f3f74536 on randombit:master.