search

randomhost / teamspeak-dark

A dark theme for TeamSpeak 3 which looks surprisingly similar to another popular voice communication software.
https://github.random-host.tv/teamspeak-dark/
BSD 3-Clause "New" or "Revised" License
59 stars 8 forks source link

Extended Info TPLs #37

Closed Bluscream closed 4 years ago

Bluscream commented 6 years ago

It would you need if you could add the stuff thats usually in extended info themes <!-- commented out --> to the TPLs so people that wan't to see them could easily uncomment them :)

Chi-Yu commented 6 years ago

I'm not a big fan of carrying around unused code in comments. It pollutes the code base and is usually forgotten when changing things so it's usually going to break at some point.

This is open source. Someone could easily fork the repository and create teamspeak-dark-extended or something like that.

Actually, what you are asking for is already there since I kept the original Replaceable variables comment in the template files. People just have to write a bit of HTML.

Bluscream commented 6 years ago

That would require another repo and resolving merge conflicts etc. I would do it if you wouldn't push so often :D (I already added a autostart entry for git pull)

svenpaulsen commented 4 years ago

I'm thinking about adding a global option like "Show advanced info" so third party themes would be able to determine wether or not to display specific information based on a template variable. Seems like a reasonable approach using the new template syntax in 3.5.x.

Chi-Yu commented 4 years ago

Not very fine-grained, but it's TeamSpeak 3. I will take it.

Chi-Yu commented 4 years ago

There is now at least one fork which adds extended info frame templates.

I'm closing this now since I doubt we are going to see the aforementioned "show advanced info" option anytime soon.